Fixed the user management page cypress issue #9384

nihal467 · 2024-12-11T15:14:02Z

Proposed Changes

Fixes #issue_number
Change 1
Change 2
More?

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

New Features
- Added a test case to verify working hours in user profiles.
- Introduced a scenario for linking and unlinking facilities for multiple users, ensuring visibility in user cards.
Bug Fixes
- Enhanced verification process for user details and linked facilities with additional assertions.
Refactor
- Updated the method for verifying working hours to check for content presence instead of input field interaction.

coderabbitai · 2024-12-11T15:14:11Z

Walkthrough

The changes in this pull request enhance the Cypress end-to-end test suite for user management. A new test case verifies the reflection of working hours in user profiles, including navigation to the profile after submitting hours. Additionally, a scenario for linking and unlinking facilities for multiple users is introduced, ensuring correct visibility in user cards. The verifyWorkingHours and verifyProfileWorkingHours methods in the ManageUserPage class are updated to check for content presence instead of input field interaction. Overall, the modifications expand test coverage while maintaining the existing structure.

Changes

File Path	Change Summary
`cypress/e2e/users_spec/UsersManage.cy.ts`	Added tests for verifying working hours in user profiles and linking/unlinking facilities for multiple users.
`cypress/pageobject/Users/ManageUserPage.ts`	Updated `verifyWorkingHours` and `verifyProfileWorkingHours` methods to check content presence instead of input field visibility.

Possibly related PRs

Rewriting UsersCreation.cy.ts according to POM approach #8930: This PR modifies the UsersCreation.cy.ts test file, which is related to user management, similar to the changes in the UsersManage.cy.ts file in the main PR that focuses on user management functionalities.
Avatar in UserAutoComplete #8967: The changes in this PR involve the UserAutocompleteFormField, which may relate to user management features, aligning with the user profile updates in the main PR.
Fixed Flaky Test in User skill management #9092: This PR addresses a flaky test in the UsersManage.cy.ts file, which is directly related to the main PR's focus on enhancing user management tests.
Users Manage Test Fix #9368: This PR modifies the UsersManage.cy.ts file to improve the user management tests, which is directly relevant to the changes made in the main PR.

Suggested labels

needs review, tested

Suggested reviewers

rithviknishad

Poem

🐇 In the land of tests where rabbits play,
New cases hop in, brightening the day.
Working hours checked, and links made right,
User cards gleam, a wonderful sight!
With every assertion, our code takes flight,
Testing together, we’ll conquer the night! 🌟

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 40ea811 and 1160d6e.

📒 Files selected for processing (1)

cypress/pageobject/Users/ManageUserPage.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

cypress/pageobject/Users/ManageUserPage.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2024-12-11T15:14:25Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`1160d6e`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/6759b2a8b6002a0008e5cdee
😎 Deploy Preview	https://deploy-preview-9384--care-ohc.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

cloudflare-workers-and-pages · 2024-12-11T15:15:47Z

Deploying care-fe with Cloudflare Pages

Latest commit:	`1160d6e`
Status:	✅ Deploy successful!
Preview URL:	https://c4827baf.care-fe.pages.dev
Branch Preview URL:	https://flaky-test.care-fe.pages.dev

View logs

coderabbitai

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

cypress/pageobject/Users/ManageUserPage.ts (1)
196-198: Consider consolidating working hours verification methods

While the implementation using cy.verifyContentPresence is good, having two similar methods (verifyWorkingHours and verifyProfileWorkingHours) with different implementations could lead to maintenance issues.

Consider consolidating both methods to use the same verification approach:
  verifyWorkingHours(expectedHours: string) {
    cy.verifyContentPresence("#view-average_weekly_working_hours", [
      expectedHours,
    ] as string[]);
  }

-  verifyProfileWorkingHours(expectedHours: string) {
-    cy.get("#view-average_weekly_working_hours").should(
-      "contain.text",
-      expectedHours,
-    );
-  }
+  verifyProfileWorkingHours(expectedHours: string) {
+    this.verifyWorkingHours(expectedHours);
+  }
cypress/e2e/users_spec/UsersManage.cy.ts (1)
308-308: Enhance test coverage for working hours verification

While verifying working hours across different views is good, consider adding negative test cases to ensure robust validation.

Add test cases for:

Non-numeric values

Negative values

Empty values

Decimal values

Example:
// Add these test cases before setting the valid working hours
const invalidInputs = ['abc', '-1', '', '23.5'];
for (const input of invalidInputs) {
  manageUserPage.clearProfessionalInfo();
  manageUserPage.typeInWeeklyWorkingHours(input);
  manageUserPage.clickSubmit();
  manageUserPage.verifyErrorText("Average weekly working hours must be a number between 0 and 168");
}

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 113dddd and 40ea811.

📒 Files selected for processing (2)

cypress/e2e/users_spec/UsersManage.cy.ts (1 hunks)
cypress/pageobject/Users/ManageUserPage.ts (1 hunks)

cypress · 2024-12-11T15:24:44Z

CARE Run #4010

Run Properties: Passed #4010 • 1160d6e543: Fixed the user management page cypress issue

Project	`CARE`
Branch Review	`flaky-test`
Run status	`Passed #4010`
Run duration	`05m 26s`
Commit	`1160d6e543: Fixed the user management page cypress issue`
Committer	`Mohammed Nihal`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`153`
View all changes introduced in this branch ↗︎

github-actions · 2024-12-11T15:56:03Z

@nihal467 Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌

fixed the user management flaky test

40ea811

nihal467 requested a review from a team as a code owner December 11, 2024 15:14

coderabbitai bot reviewed Dec 11, 2024

View reviewed changes

fixed the id

1160d6e

nihal467 self-assigned this Dec 11, 2024

rithviknishad approved these changes Dec 11, 2024

View reviewed changes

rithviknishad merged commit 3ba5dc6 into develop Dec 11, 2024
58 checks passed

rithviknishad deleted the flaky-test branch December 11, 2024 15:55

coderabbitai bot mentioned this pull request Dec 18, 2024

Fixed Flaky Test in cypress develop branch #9492

Merged

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed the user management page cypress issue #9384

Fixed the user management page cypress issue #9384

nihal467 commented Dec 11, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 11, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Dec 11, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 11, 2024 •

edited

Loading

coderabbitai bot left a comment

cypress bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024

Fixed the user management page cypress issue #9384

Fixed the user management page cypress issue #9384

Conversation

nihal467 commented Dec 11, 2024 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Dec 11, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Dec 11, 2024 • edited Loading

✅ Deploy Preview for care-ohc ready!

cloudflare-workers-and-pages bot commented Dec 11, 2024 • edited Loading

Deploying care-fe with Cloudflare Pages

coderabbitai bot left a comment

Choose a reason for hiding this comment

cypress bot commented Dec 11, 2024 • edited Loading

CARE Run #4010

github-actions bot commented Dec 11, 2024

nihal467 commented Dec 11, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Dec 11, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Dec 11, 2024 •

edited

Loading

cloudflare-workers-and-pages bot commented Dec 11, 2024 •

edited

Loading

cypress bot commented Dec 11, 2024 •

edited

Loading